fix: add locale fallback for translation variants #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add locale fallback logic to support regional locale variants (e.g.,
de-DE, de_DE) that fall back to base locale (de) when exact match
is not found.
This fixes an issue where German translations were not loading in
Scratch environments that use locale codes like 'de-DE' instead of
just 'de'. The setupTranslations() function now:
1. Checks for exact locale match first (e.g., 'de-DE')
2. Falls back to base locale if no exact match (e.g., 'de-DE' -> 'de')
3. Handles both hyphen and underscore separators ('de-DE' and 'de_DE')
Tested with:
- German (de-DE, de_DE) -> successfully loads 'de' translations
- Japanese and other existing locales continue to work
- English fallback remains unchanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add locale fallback logic to support regional locale variants (e.g., de-DE, de_DE) that fall back to base locale (de) when exact match is not found.
This fixes an issue where German translations were not loading in Scratch environments that use locale codes like 'de-DE' instead of just 'de'. The setupTranslations() function now:
Tested with: